NC | Docs | Update Ceph S3 Tests Instructions in NC + Fix Bucket Policy All Principals #8374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadavMiz
reviewed
Sep 17, 2024
shirady
force-pushed
the
nsfs-nc-docs-bucket-policy-fix-and-ceph-update
branch
from
a2ccf06
to
c5c5307
Compare
|
LGTM |
nadavMiz
approved these changes
Sep 18, 2024
shirady
force-pushed
the
nsfs-nc-docs-bucket-policy-fix-and-ceph-update
branch
2 times, most recently
from
7fcba2b
to
c14960e
Compare
1. Add manual instructions for testing Ceph S3 tests in NC deployment. 2. Fix the small mistake in all principals example in bucket policy. Signed-off-by: shirady <[email protected]>
shirady
force-pushed
the
nsfs-nc-docs-bucket-policy-fix-and-ceph-update
branch
from
c14960e
to
c477b04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues:
Testing Instructions: